This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
refactor(nuxt)!: remove support for 404.vue shorthand
#8809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for nuxt3-docs canceled.
|
danielroe
added
🍰 p2-nice-to-have
atinux
approved these changes
Nov 8, 2022
pi0
approved these changes
Nov 9, 2022
pi0
changed the title
404.vue shorthand404.vue shorthand
BenjaminOddou
added a commit
to BenjaminOddou/portfolio
that referenced
this pull request
Nov 9, 2022
- resolve the breaking change [#8809](nuxt/framework#8809)
Merged
|
hello, |
|
@ibrahim-990 If you are experiencing an issue, please open a new issue with a minimal reproduction 🙏 |
|
i open |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#14702
❓ Type of change
📚 Description
This PR removes support for the
404.vueshorthand (mapping to a catchall with 404 status code). This was confusing when users also had a manual catchall, such as[...slug].vue(as the latter would never be hit). And it also separated out the 404 error page fromerror.vuewhich was used to render every other error page.👉 Migration
404.vuepage to[...slug].vue.<script setup> + setResponseStatus(404) </script>📝 Checklist